This site uses cookies. By continuing to browse this site, you are agreeing to our Cookie Policy.
yurseli wrote:
It looks really nice. I was trying to integrate Xterium's new design into my own system, but adding plugins and things like that is really tiring. I wish I had seen this project sooner and waited for it.
yurseli wrote:
Wouldn't rendering the entire galaxy simultaneously create performance issues for large datasets? It would significantly increase server load, like fetching a large amount of data.
amamoslavida_ wrote:
Great work nice UI. I have given a small test and found some issues, a few recommendations below.
1- implement google recaptcha ( otherwise people can abuse your login system, it is possible for someone to have infinite accounts with curl etc ).
2- you need "false controll" , meaning when you use $db->selectSingle, if data is not found returns false, and if you try to access array on boolean it throws error, example page.
sm.makeit.uno/game.php?page=playerCard ( going to throw error. ) One can fill your database with those errors just by auto refreshing page, because ticket system puts that in database.
need something like
# example
$id = HTTP::_GP('id',0); // default value 0
$sql = "SELECT * FROM %%USERS%% WHERE id = :id;";
$user_info = $db->selectSingle($sql, [':id' => $id]);
if (!$user_info) { return; } // or print msg
$user_info['name'] // no problems.
this page is also problematic
sm.makeit.uno/game.php?page=changelog ( probably not implemented, i have that on my signature project, if you are interested)
yurseli wrote:
projenin kurulu bir demosu varmı koray
amamoslavida_ wrote:
Great work nice UI. I have given a small test and found some issues, a few recommendations below.
1- implement google recaptcha ( otherwise people can abuse your login system, it is possible for someone to have infinite accounts with curl etc ).
2- you need "false controll" , meaning when you use $db->selectSingle, if data is not found returns false, and if you try to access array on boolean it throws error, example page.
sm.makeit.uno/game.php?page=playerCard ( going to throw error. ) One can fill your database with those errors just by auto refreshing page, because ticket system puts that in database.
need something like
# example
$id = HTTP::_GP('id',0); // default value 0
$sql = "SELECT * FROM %%USERS%% WHERE id = :id;";
$user_info = $db->selectSingle($sql, [':id' => $id]);
if (!$user_info) { return; } // or print msg
$user_info['name'] // no problems.
this page is also problematic
sm.makeit.uno/game.php?page=changelog ( probably not implemented, i have that on my signature project, if you are interested)
amamoslavida_ wrote:
imzadaki linkin kurulumu sıkıntısız olmalı, demo olarak hostlamıyorum. versiyon da pek iyi durumda değil açıkcası tonla problem var, özellikle UI sıkıntılı. sadece hobi project, zaman buldukça geliştirmeye çalışıyorum. belki işinize yarayacak birşeyler vardır (flight sim, maden toplama gibi ). git commit sayfasından yapılan değişiklere göz atabilirsiniz.yurseli wrote:
projenin kurulu bir demosu varmı koray
1 Guest
